feat: add option to add __typename to interfaces
#10523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gabrielschulhof
force-pushed
the
add-concrete-type-names-to-interface-__typename
branch
from
2fc7ab8 to
dc25d42
Compare
The new option `addTypenameToInterfaces` adds the `__typename` field to types resulting from interfaces. The field admits a union of string values, each the name of one of the concrete types implementing the interface. Also adds field `typeUnionOperator` to class `BaseVisitor` so we don't have the literal `' | '` in a bunch of places.
gabrielschulhof
force-pushed
the
add-concrete-type-names-to-interface-__typename
branch
from
dc25d42 to
28f21a8
Compare
gabrielschulhof
changed the title
__typename to interfaces__typename to interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option
addTypenameToInterfacesadds the__typenamefield to types resulting from interfaces. The field admits a union of string values, each the name of one of the concrete types implementing the interface.Also adds field
typeUnionOperatorto classBaseVisitorso we don't have the literal' | 'in a bunch of places.🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This will allow us to treat incoming objects uniformly using their parent type, and will also allow us to type cast appropriately when the handling of the individual object begins to diverge based on their type.
Related #10522
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
A unit test is included. The remaining unit tests verify that no change occurs when the option is absent.
Test Environment:
Checklist: